Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust useForm to more gracefully handle page refreshes #110

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Adjust useForm to more gracefully handle page refreshes #110

merged 1 commit into from
Feb 12, 2025

Conversation

benmartin-coforma
Copy link
Contributor

Description

This PR should fix the autosave refresh bug without breaking anything else.

Related ticket(s)

N/A

How to test

To verify the bug is fixed:

  1. Create a new report
  2. Navigate to a page with more than one text input
  3. Enter a value in one of the text inputs
  4. Blur that field - which will trigger an autosave
  5. Refresh the browser window
  6. Enter a value in a different text input
  7. Blur that field - which will trigger another autosave
  8. Refresh the browser window
  9. Note that both inputs still contain your values

Also:

  1. idk, try a bunch of form... stuff. It should all work good.

Important updates

n/a

Author checklist

  • I have performed a self-review of my code
  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary

@codeclimate CodeClimate
Copy link

codeclimate bot commented Feb 6, 2025

Code Climate has analyzed commit 7d38a33 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (90% is the threshold).

This pull request will bring the total coverage in the repository to 93.8% (0.0% change).

View more on Code Climate.

ailZhou
ailZhou approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@ailZhou ailZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the code and tested on deploy. no issues found, looks go to me!

@benmartin-coforma benmartin-coforma merged commit 3fa9fd4 into main Feb 12, 2025
21 checks passed
@benmartin-coforma benmartin-coforma deleted the handle-page-refresh branch February 12, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BearHanded BearHanded BearHanded approved these changes

@ailZhou ailZhou ailZhou approved these changes

@braxex braxex Awaiting requested review from braxex braxex is a code owner

Assignees

@benmartin-coforma benmartin-coforma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benmartin-coforma @BearHanded @ailZhou